Skip to content

feat: also ignore missing and empty authorized_keys file when SSHCOMMAND_IGNORE_LIST_WARNINGS is set to true #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josegonzalez merged 2 commits into from
Mar 12, 2025
Merged

feat: also ignore missing and empty authorized_keys file when SSHCOMMAND_IGNORE_LIST_WARNINGS is set to true #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76b229b
feat: also ignore missing and empty authorized_keys file when SSHCOMM…
josegonzalez Mar 12, 2025
a0c6509
fix: invert check
josegonzalez Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions sshcommand
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,30 @@ sshcommand-list() {
declare desc="Lists SSH keys by user, an optional name and a optional output format (JSON)"
declare userhome USER="$1" NAME="$2" OUTPUT_TYPE="${3:-$2}"
[[ -z "$USER" ]] && log-fail "Usage: sshcommand list" "$(fn-args "sshcommand-list")"
SSHCOMMAND_IGNORE_LIST_WARNINGS="${SSHCOMMAND_IGNORE_LIST_WARNINGS:-false}"

getent passwd "$USER" >/dev/null || log-fail "\"$USER\" is not a user on this system"
userhome=$(sh -c "echo ~$USER")
[[ -e "$userhome/.ssh/authorized_keys" ]] || log-fail "authorized_keys not found for $USER"
[[ -s "$userhome/.ssh/authorized_keys" ]] || log-fail "authorized_keys is empty for $USER"
if [[ ! -e "$userhome/.ssh/authorized_keys" ]]; then
log-warn "authorized_keys not found for $USER"
if [[ "$SSHCOMMAND_IGNORE_LIST_WARNINGS" == "false" ]]; then
return 1
fi
return
fi

if [[ ! -s "$userhome/.ssh/authorized_keys" ]]; then
log-warn "authorized_keys is empty for $USER"
if [[ "$SSHCOMMAND_IGNORE_LIST_WARNINGS" == "false" ]]; then
return 1
fi

if [[ "$OUTPUT_TYPE" == "json" ]]; then
echo "[]"
fi
return
fi

SSHCOMMAND_IGNORE_LIST_WARNINGS="${SSHCOMMAND_IGNORE_LIST_WARNINGS:-false}"
if ! fn-verify-file "$userhome/.ssh/authorized_keys" && [[ "$SSHCOMMAND_IGNORE_LIST_WARNINGS" == "false" ]]; then
return 1
fi
Expand Down