add Linus support (beyond OSX support)#6
Open
martinjackson wants to merge 1 commit intodonavon:masterfrom
martinjackson:patch-1
Open
add Linus support (beyond OSX support)#6martinjackson wants to merge 1 commit intodonavon:masterfrom martinjackson:patch-1
martinjackson wants to merge 1 commit intodonavon:masterfrom
martinjackson:patch-1
Conversation
open command on Linux attempt to open a new terminal. OSX uses open, Linux uses xdg-open.
donavon
reviewed
Mar 21, 2019
|
|
||
| unameOut="$(uname -s)" | ||
| case "${unameOut}" in | ||
| Linux*) xdg-open https://github.com/donavon/hook-flow;; |
Owner
There was a problem hiding this comment.
any way to DRY this up so the URL doesn't have to be repeated 4 times?
Author
|
Yes, will submit the following... Something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open command on Linux attempt to open a new terminal. OSX uses open to view a image or a web page, Linux equivalent is xdg-open.