Conversation
…ilure Issue: - Closes #388 Why: - Vector search visualization passed targetType-only scope with objectId=null. - PostgreSQL could not infer the nullable named parameter type in object-scoped vector SQL. What: - Cast nullable objectType/objectId predicates to varchar in PgVector object-scoped search SQL. - Add PostgreSQL/Testcontainers regression tests for searchByObject and hybridSearchByObject with objectId=null. - Add visualization service coverage for targetTypes using objectType-only vector scope. Validation: - ./gradlew :starter:studio-platform-starter-ai:test :starter:studio-platform-starter-ai-web:test :studio-platform-ai:test (PASS) - ./gradlew test (PASS) - git diff --check (PASS) AI-Assisted: Yes Subagent used: Yes Delegated scope: code review for issue #388 before and after test hardening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
targetTypes를 지정하면objectId=null인 object type 단독 검색을 수행합니다.:objectId IS NULL형태의 nullable named parameter 타입을 추론하지 못해PROJECTION_SEARCH_FAILED가 발생했습니다.What
searchByObject,hybridSearchByObjectSQL의 nullableobjectType/objectIdpredicate에CAST(... AS varchar)를 적용했습니다.objectId == null검색 경로를 검증했습니다.targetTypes를 objectType-only scope로 호출하는 계약을 테스트로 고정했습니다.Related Issues
Validation
./gradlew :starter:studio-platform-starter-ai:test --tests 'studio.one.platform.ai.adapters.vector.PgVectorStoreAdapterV2PostgresTest' :studio-platform-ai:test --tests 'studio.one.platform.ai.core.vector.VectorSqlSetContractTest'./gradlew :starter:studio-platform-starter-ai:test :starter:studio-platform-starter-ai-web:test :studio-platform-ai:test./gradlew testgit diff --checkRisk / Rollback
AI / Subagent Usage
Checklist
AI-Assistedvalue is correct