Conversation
…link resolution. Most path operations are now done in the OS semantics (i.e. using filepath/path).
stampy88
reviewed
Mar 6, 2025
| const NodePrefix = "node:" | ||
|
|
||
| func (r *RequireModule) resolvePath(base, name string) string { | ||
| if r.r.pathResolver != nil { |
Contributor
There was a problem hiding this comment.
you could change the constructor to default to the DefaultPathResolver instead of checking this every time. e.g.
func NewRegistry(opts ...Option) *Registry {
r := &Registry{
pathResolver : DefaultPathResolver
}
...
Owner
Author
There was a problem hiding this comment.
This would break the use of zero-value Registry. A similar mechanism is already implemented for SourceLoader.
# Conflicts: # go.mod # go.sum
benallfree
pushed a commit
to benallfree/goja_nodejs
that referenced
this pull request
May 3, 2025
…link resolution. Most path operations are now done in the OS semantics (i.e. using filepath/path). (dop251#101)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83