[Function] support vec hex #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappenLee
reviewed
Oct 15, 2021
be/src/vec/functions/function.h
Outdated
|
|
||
| void get_lambda_argument_types(DataTypes& arguments) const override { | ||
| check_number_of_arguments(arguments.size()); | ||
| // check_number_of_arguments(arguments.size()); |
zbtzbtzbt
force-pushed
the
function_hex
branch
from
48888fa to
c4dc213
Compare
zbtzbtzbt
force-pushed
the
function_hex
branch
from
c4dc213 to
aec440d
Compare
HappenLee
reviewed
Oct 26, 2021
be/src/vec/data_types/data_type.h
Outdated
| using DataTypePtr = std::shared_ptr<const IDataType>; | ||
| using DataTypes = std::vector<DataTypePtr>; | ||
|
|
||
| struct defaultDataTypes{ |
| *res = hexDigits[(src_str[i] >> 4) & 0x0F]; | ||
| std::copy(res, res + 2, dst_str + 2 * i); | ||
| } | ||
| return 2*length; |
| }; | ||
|
|
||
| // support hex variadic | ||
| struct hexStringDataTypes{ |
| } | ||
|
|
||
| DataTypes get_variadic_argument_types_impl() const override{ | ||
| return argument_types::types; |
Contributor
There was a problem hiding this comment.
这个是不是应该和name一样放在Impl类里面，这样扩展模板容易导致类膨胀的问题
Contributor
Author
There was a problem hiding this comment.
不能这样，像name那种写法的话，使用这个类的非重载函数都需要实现一遍。用这种默认参数的形式，其他代码不需要改动。
Contributor
There was a problem hiding this comment.
你让所有使用这个类的Impl统一继承一个公共类就行了
Contributor
Author
There was a problem hiding this comment.
提交的这一版是未使用SFINAE方式的版本
| if (iter != function_creators.end()) { | ||
| return iter->second()->build(arguments, return_type); | ||
| } | ||
| LOG(INFO) << "get_function() return nullptr in simple_function_factory.h"; |
| '_ZN5doris13MathFunctions5unhexEPN9doris_udf15FunctionContextERKNS1_9StringValE', '', '', 'vec', ''], | ||
| [['unhex'], 'STRING', ['STRING'], | ||
| '_ZN5doris13MathFunctions5unhexEPN9doris_udf15FunctionContextERKNS1_9StringValE', '', '', '', ''], | ||
| '_ZN5doris13MathFunctions5unhexEPN9doris_udf15FunctionContextERKNS1_9StringValE', '', '', 'vec', ''], |
Contributor
There was a problem hiding this comment.
这个函数我看源码是always nullable的？
zbtzbtzbt
force-pushed
the
function_hex
branch
2 times, most recently
from
825a84d to
12d42d5
Compare
HappenLee
reviewed
Oct 28, 2021
Contributor
HappenLee
left a comment
HappenLee
left a comment
There was a problem hiding this comment.
有一些小的格式问题， 改一下，一些没用的代码删除一下
be/src/vec/functions/function.h
Outdated
| public: | ||
| FunctionBasePtr build(const ColumnsWithTypeAndName& arguments, const DataTypePtr& return_type) const final { | ||
|
|
||
| if(!return_type->equals(*get_return_type(arguments))){ |
zbtzbtzbt
force-pushed
the
function_hex
branch
2 times, most recently
from
08f1f02 to
a265c31
Compare
HappenLee
pushed a commit
that referenced
this pull request
Nov 15, 2021
* support function hex, fix hex(0)=0, fix unhex bug, support nullable. * format code and delete debug code.
HappenLee
pushed a commit
that referenced
this pull request
Dec 16, 2021
* support function hex, fix hex(0)=0, fix unhex bug, support nullable. * format code and delete debug code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
1.使用了支持函数重载的注册逻辑 #201 ，支持hex对int和string两种类型参数
2.相比之前关闭的pr，vec版本也修复了hex(0)=0的bug，apache/doris#6837
3.相比之前关闭的pr，使得向量化和非向量化的hex函数对于相同输入，输出保持一致
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...