xt-declare-target-ctors: Update for GCC#3
Open
tschwinge wants to merge 1 commit intodoru1004:mainfrom
Open
Conversation
It's not clear from the revision log what compiler the xt-declare-target-ctors
test has been written against, in particular, its
'xt-declare-target-ctors/expected' file. But it must've been a long time ago.
Updating this for current GCC:
1. Like on the host, also for offloading: destructors run in reverse order of
constructors.
2. Offloading is initialized (and with that, offloading constructors are run)
upon encountering the first offloading construct (here:
'#pragma omp target'), and offloading is shut down (and with that,
offloading destructors are run) at the end of 'main', before destructing
host objects.
Author
|
Before merging, we should check what other current compilers are doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear from the revision log what compiler the xt-declare-target-ctors test has been written against, in particular, its
'xt-declare-target-ctors/expected' file. But it must've been a long time ago.
Updating this for current GCC: