Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #261 +/- ##
============================================
- Coverage 64.05% 64.03% -0.02%
+ Complexity 347 334 -13
============================================
Files 49 47 -2
Lines 1764 1738 -26
============================================
- Hits 1130 1113 -17
+ Misses 634 625 -9 ☔ View full report in Codecov by Sentry. |
alexmerlin
requested changes
Jul 10, 2024
alexmerlin
requested changes
Jul 12, 2024
Member
alexmerlin
left a comment
There was a problem hiding this comment.
src/App/assets/js/components/*.js- most of the files have no/multiple empty lines at the end of the file- also, this error reported by SymfonyInsight
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
pinclau
previously requested changes
Jul 12, 2024
Signed-off-by: MarioRadu <magda_marior@yahoo.com>
alexmerlin
approved these changes
Jul 14, 2024
arhimede
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.