implemented unit tests, added phpcs, static-analysis and run unit tes…

[poprazvan17]

…t github actions

[alexmerlin]

Please fix the following items:

1. Make sure there is an empty line at the end of each the following files:

• .github/workflows/cs-tests.yml
• .github/workflows/static-analysis.yml
• .github/workflows/unit-tests.yml
• phpcs.xml
• phpunit.xml
• psalm.xml
  In case that they already have an empty line at the end, make sure the line endings are set to LF (NOT CRLF).

2. All file header blocks should be removed:

/**

• @see https://github.com/dotkernel/dot-authentication/ for the canonical source repository
• @copyright Copyright (c) 2017 Apidemia (https://www.apidemia.com)
• @license https://github.com/dotkernel/dot-authentication/blob/master/LICENSE.md MIT License
  */

3. Make sure that the below commands report no error:

• composer cs-check
• composer static-analysis
• composer test

[alexmerlin]

Also, please add Symfony Insight badge.
If you don't have the snippet for it, ask @arhimede to create it.

[alexmerlin]

@poprazvan17 A couple of my comments still aren't resolved (you can also see them above, not being marked as resolved).
I'll summarize:

1. for consistency across our packages, please move test file back to directory test (make sure you change the directory name, in composer.json, phpcs.xml and in phpunit.xml)
2. please add Symfony Insight badge. If you don't have the snippet for it, ask @arhimede to create it.
3. see my unresolved comments across the PR

[alexmerlin]

2 observations:

1. composer.json: The whole file appears as modified. Did you modify line endings from CRLF to LF? Or vice-versa? (being a fork PR, I cannot see)
2. don't forget to add Symfony Insight badge

Other than these, LGTM.

[poprazvan17]

1. I modified from CRLF to LF 2. I asked Julian for the Symfony Insight badge. Thank you! În mie., 12 iul. 2023 la 21:19, Alex Karajos ***@***.***> a scris:

…

2 observations: 1. composer.json: The whole file appears as modified. Did you modify line endings from CRLF to LF? Or vice-versa? (being a fork PR, I cannot see) 2. don't forget to add Symfony Insight badge Other than these, LGTM. — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBBMRFGFYB3Y737OTNM2LX3XP3TELANCNFSM6AAAAAA2EI5DCM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alexmerlin]

@poprazvan17 Please insert a new line between the Github license and the SymfonyInsight badge, so the SymfonyInsight badge is rendered on a new line.

[alexmerlin]

@poprazvan17 Also, I see that composer.json is CRLF, please convert it to LF.
SymfonyInsight also reports an incorrect end of file.