Skip to content

issue #18 - Type hint and access modifiers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexmerlin merged 6 commits into from
Aug 17, 2023
Merged

issue #18 - Type hint and access modifiers #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca2894f
added static analysis badge
poprazvan17 Jul 20, 2023
085e945
added static analysis badge
poprazvan17 Jul 20, 2023
e7726b3
issue 18- Type hint and access modifiers
poprazvan17 Aug 14, 2023
ecdfe1f
issue 18- Type hint and access modifiers
poprazvan17 Aug 17, 2023
d7db9f6
Merge branch 'dotkernel:2.0' into 2.0
poprazvan17 Aug 17, 2023
93b1c28
issue 18- Type hint and access modifiers
poprazvan17 Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/AuthenticationResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@

class AuthenticationResult
{
protected const FAILURE = 0;
protected const SUCCESS = 1;
protected const FAILURE_INVALID_CREDENTIALS = -1;
protected const FAILURE_IDENTITY_AMBIGUOUS = -2;
protected const FAILURE_IDENTITY_NOT_FOUND = -3;
protected const FAILURE_UNCATEGORIZED = -4;
protected const FAILURE_MISSING_CREDENTIALS = -5;
public const FAILURE = 0;
public const SUCCESS = 1;
public const FAILURE_INVALID_CREDENTIALS = -1;
public const FAILURE_IDENTITY_AMBIGUOUS = -2;
public const FAILURE_IDENTITY_NOT_FOUND = -3;
public const FAILURE_UNCATEGORIZED = -4;
public const FAILURE_MISSING_CREDENTIALS = -5;

protected int $code;

protected IdentityInterface $identity;
protected ?IdentityInterface $identity = null;

protected string $message = '';

Expand Down
10 changes: 5 additions & 5 deletions test/AuthenticationResultTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@
class AuthenticationResultTest extends TestCase
{
protected AuthenticationResult $subject;
protected IdentityInterface|MockObject $indentyInterfaceMock;
protected IdentityInterface|MockObject $identityInterfaceMock;

/**
* @throws Exception
*/
protected function setUp(): void
{
$this->indentyInterfaceMock = $this->createMock(IdentityInterface::class);
$this->indentyInterfaceMock->method('getId')->will($this->returnValue(10));
$this->indentyInterfaceMock->method('getName')->willReturn('username');
$this->subject = new AuthenticationResult(2, 'valid', $this->indentyInterfaceMock);
$this->identityInterfaceMock = $this->createMock(IdentityInterface::class);
$this->identityInterfaceMock->method('getId')->will($this->returnValue(10));
$this->identityInterfaceMock->method('getName')->willReturn('username');
$this->subject = new AuthenticationResult(2, 'valid', $this->identityInterfaceMock);
}

public function testAuth()
Expand Down