changed interface method getId return type#24
Merged
pinclau merged 2 commits intodotkernel:2.0from Oct 11, 2023
Merged
Conversation
alexmerlin
requested changes
Oct 11, 2023
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Should we replace with mixed because getId could also return null?
If so, then please also fix the phpcs error reported here (remove the comment with the return type)
alexmerlin
approved these changes
Oct 11, 2023
Member
Author
|
@alexmerlin yes, in some cases can be null, especially when is used with do-user package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.