Added tests, psalm and phpcs fixes#12
Merged
alexmerlin merged 4 commits into3.0from Aug 18, 2023
Merged
Conversation
Member
Author
|
@arhimede a symfony insight badge would be needed |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #12 +/- ##
=======================================
Coverage ? 100.00%
Complexity ? 49
=======================================
Files ? 7
Lines ? 132
Branches ? 0
=======================================
Hits ? 132
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Aug 17, 2023
Closed
Closed
alexmerlin
requested changes
Aug 17, 2023
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Please restore file permissions (755 -> 644) for the following files:
.gitignoreCHANGELOG.mdLICENSE.mdOSSMETADATAREADME.mdcomposer.json
alexmerlin
requested changes
Aug 18, 2023
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
I just noticed that the permissions have changed on the files in the src directory too.
Please restore those as well (755 -> 644).
Closed
added SymfonyInsight badge
alexmerlin
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10