Skip to content

Unit tests, psalm & phpcs#15

Merged
alexmerlin merged 6 commits into4.0from
issue-19
Aug 14, 2023
Merged

Unit tests, psalm & phpcs#15
alexmerlin merged 6 commits into4.0from
issue-19

Conversation

@marioradu05
Copy link
Copy Markdown
Member

No description provided.

@marioradu05 marioradu05 requested a review from alexmerlin August 12, 2023 14:39
@alexmerlin alexmerlin linked an issue Aug 12, 2023 that may be closed by this pull request
@alexmerlin alexmerlin linked an issue Aug 14, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the following:

  1. README.md:
  • add Static analysis and SymfonyInsight badges
  • on the line with PHP from Packagist replace 4.0.1 with 4.2.0
  • remove extra empty lines where there's more than 1

Comment thread .gitignore Outdated
Comment thread src/FormElementManager.php
Comment thread src/Factory/FormAbstractServiceFactory.php Outdated
Comment thread src/Factory/FormAbstractServiceFactory.php
Comment thread src/Factory/FormAbstractServiceFactory.php
Comment thread test/Factory/FormAbstractServiceFactoryTest.php
Comment thread test/Factory/FormAbstractServiceFactoryTest.php
Comment thread src/ConfigProvider.php Outdated
Comment thread composer.json Outdated
Comment thread composer.json
@marioradu05 marioradu05 requested a review from alexmerlin August 14, 2023 09:12
@alexmerlin alexmerlin merged commit 47651be into 4.0 Aug 14, 2023
@alexmerlin alexmerlin deleted the issue-19 branch August 14, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

green badge Unit Test

2 participants