issue77#78
Conversation
|
To adhere to PSR-3, only the |
alexmerlin
left a comment
There was a problem hiding this comment.
IMO, I would keep src/Exception/InvalidArgumentException.php, because this was the purpose of having our own version of an exception: we can introduce modifications in the package, but the implementors do not need to adapt their code, they can continue using Dot\Log\Exception\InvalidArgumentException.
Keeping that file, you can undo almost the entire PR and you'll probably have end up having one single file modified.
This reverts commit af1076c.
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
alexmerlin
left a comment
There was a problem hiding this comment.
Also, modify src/Exception/InvalidArgumentException.php:
<?php
declare(strict_types=1);
namespace Dot\Log\Exception;
class InvalidArgumentException extends \Psr\Log\InvalidArgumentException
{
}This is what I meant in my previous review.
Now that Dot\Log\Exception\InvalidArgumentException extends Psr\Log\InvalidArgumentException, which extends \InvalidArgumentException we can use our own InvalidArgumentException everywhere because it is an instance of all the exteded classes so it will be accepted everywhere.
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
|
As I mentioned in my first review:
👍 |
Removed
src/Exception/InvalidArgumentException.phpand replaced it's usage withPsr\Log\InvalidArgumentException.Closes #77