Skip to content

removed unused code inherited from version 4.0#73

Merged
arhimede merged 7 commits into5.0from
issues-70
Dec 6, 2024
Merged

removed unused code inherited from version 4.0#73
arhimede merged 7 commits into5.0from
issues-70

Conversation

@SergiuBota1
Copy link
Copy Markdown
Member

Removed unused code inherited from version 4.0
close #70

Removing unused code also fixed phpcs erros for mail.global.php.dist
close #72

Signed-off-by: sergiu <sergiubota@rospace.com>
@SergiuBota1 SergiuBota1 added the 5.0 label Dec 4, 2024
Signed-off-by: sergiu <sergiubota@rospace.com>
Signed-off-by: sergiu <sergiubota@rospace.com>
@SergiuBota1 SergiuBota1 removed the request for review from Jurj-Bogdan December 4, 2024 14:23
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Signed-off-by: sergiu <sergiubota@rospace.com>
@alexmerlin
Copy link
Copy Markdown
Member

Just to confirm, according to the mailer CHANGELOG:

  • auth_mode has been removed in version 4.4.0 - this was the equivalent of our connection_class config (as mentioned in the old mailer docs)

@alexmerlin
Copy link
Copy Markdown
Member

FYI, besides regular SmtpTransport there is also EsmtpTransport, which seems to add many enhancements to the SMTP protocol. Comparison here: https://www.geeksforgeeks.org/what-is-esmtp-extended-simple-mail-transfer-protocol/

Signed-off-by: sergiu <sergiubota@rospace.com>
Comment thread config/mail.global.php Outdated
Comment thread docs/book/v5/configuration.md Outdated
Comment thread docs/book/v5/transports.md Outdated
Comment thread docs/book/v5/transports.md Outdated
Comment thread test/CommonTrait.php Outdated
Signed-off-by: sergiu <sergiubota@rospace.com>
Copy link
Copy Markdown
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final tweaks... 🤞

Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
Comment thread config/mail.global.php.dist Outdated
@alexmerlin
Copy link
Copy Markdown
Member

@arhimede Also note that since version 6.2, symfony/mailer has a command for sending test emails that might come handy when testing mail configurations.

Signed-off-by: sergiu <sergiubota@rospace.com>
@arhimede arhimede merged commit 5733ca1 into 5.0 Dec 6, 2024
@arhimede arhimede deleted the issues-70 branch December 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run phpcs on mail.global.php.dist connection_class ?

3 participants