Issue #7: Implemented unit tests, cs-check, static analysis.#8
Merged
alexmerlin merged 11 commits intodotkernel:3.0from Jul 28, 2023
Merged
Issue #7: Implemented unit tests, cs-check, static analysis.#8alexmerlin merged 11 commits intodotkernel:3.0from
alexmerlin merged 11 commits intodotkernel:3.0from
Conversation
alexmerlin
requested changes
Jul 18, 2023
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Please fix the following:
- add empty line to the end of
CHANGELOG.mdandconfig/response-header.global.php.distas reported here - in preparation for a
3.2.0release, please replace on the line with PHP from Packagist the string3.1.0with3.2.0 - for consistency across our packages, let's rename the
testsdirectory totest - add test for
src/ConfigProvider
alexmerlin
requested changes
Jul 20, 2023
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
ResponseHeaderMiddleware::addHeaders test examples
alexmerlin
requested changes
Jul 28, 2023
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Now that you are verifying that the headers are being added correctly, let's also check if their value is the same as the one in the configuration.
alexmerlin
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.