Skip to content

Implemented tests, code sniffer, psalm and laminas coding standard#25

Merged
alexmerlin merged 6 commits intodotkernel:5.0from
pinclau:5.0
Jul 28, 2023
Merged

Implemented tests, code sniffer, psalm and laminas coding standard#25
alexmerlin merged 6 commits intodotkernel:5.0from
pinclau:5.0

Conversation

@pinclau
Copy link
Copy Markdown
Member

@pinclau pinclau commented Jul 26, 2023

@alexmerlin please review this
related to #24 #23

This was linked to issues Jul 26, 2023
Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread composer.json Outdated
Comment thread composer.json
Comment thread test/SessionMiddlewareTest.php
Comment thread test/Factory/ContainerAbstractServiceFactoryTest.php
Comment thread test/Factory/SessionMiddlewareFactoryTest.php
Comment thread test/Factory/SessionMiddlewareFactoryTest.php
Comment thread test/Factory/SessionOptionsFactoryTest.php
Copy link
Copy Markdown
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 unresolved items, please fix them and see my comment on README.md.

Comment thread README.md
@alexmerlin alexmerlin merged commit f5ab5ad into dotkernel:5.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

green badge Code quality

3 participants