Skip to content

Blazor binding updates#19799

Merged
guardrex merged 1 commit into
masterfrom
guardrex/blazor-binding-updates
Sep 9, 2020
Merged

Blazor binding updates#19799
guardrex merged 1 commit into
masterfrom
guardrex/blazor-binding-updates

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Sep 8, 2020

Fixes #19789

Internal Review Topic (links to section)

  • The approaches now avoid writing to a component parameter and use a backing field instead.
  • Using the getter/setter approach that Ryan showed seems to only work when the component writes to the param per his original example. For this PR, I have the method that calls the binding delegate (OnPasswordChanged) make the checks. If that's not right, let me know how to handle that scenario. 👂 Even if that is the right spot, is calling return Task.CompletedTask; the right thing for a validation failure there? 👂 It seems to work well.

cc: @mrlife

@guardrex guardrex merged commit b70e1eb into master Sep 9, 2020
@guardrex guardrex deleted the guardrex/blazor-binding-updates branch September 9, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data binding example shows component overwriting its own parameter value

1 participant