Skip to content

IdS with WebSockets and Server-Sent Events#20269

Merged
guardrex merged 7 commits into
masterfrom
guardrex-patch-2
Oct 22, 2020
Merged

IdS with WebSockets and Server-Sent Events#20269
guardrex merged 7 commits into
masterfrom
guardrex-patch-2

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Oct 22, 2020

Fixes #17751

Internal Review Topic (links to section)

Brennan ... I'm winging this one even more than usual from the context on the issue. I need help with it ...

  • Is this the best spot?
  • Are these remarks sufficient/correct?
  • Is Caleb's code good to provide?

@BrennanConroy
Copy link
Copy Markdown
Member

I don't think this belongs in Blazor docs as it's specific to using SignalR directly. I would probably put it in the signalr/authn-and-authz doc.

@guardrex
Copy link
Copy Markdown
Collaborator Author

I'll move it.

Does it warrant a cross-link from the Blazor IdS topic because Caleb said ...

It does not cover the Identity Server case where AddIdentityServerJwt() is used instead, which is the default for Blazor WebAssembly apps scaffolded with authentication.

... implying that this was for a Blazor scenario in his case.

@BrennanConroy
Copy link
Copy Markdown
Member

implying that this was for a Blazor scenario in his case

Right, they were using SignalR in Blazor WASM, and you'll notice that they commented on the SignalR docs because it's a SignalR scenario. The only reason Blazor is mentioned is because the scaffolding for a Blazor app adds IdentityServerJwt by default. Anyone using IdentityServerJwt with SignalR outside of a Blazor app will have a similar issue.

I could see a possible cross-reference in the Blazor-Wasm with SignalR tutorial as a potential "next steps, adding auth" type of thing.

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Oct 22, 2020

Seems like it goes in the same section. (I try to avoid unpaired child sections.)

Does this compose well now?

@guardrex guardrex changed the title Blazor IdS with WebSockets IdS with WebSockets and Server-Sent Events Oct 22, 2020
@BrennanConroy
Copy link
Copy Markdown
Member

Should we have subsections for this to make it more obvious that this section is for IdentityServer and the other one is for the built in Jwt auth? Otherwise, looks good

@guardrex
Copy link
Copy Markdown
Collaborator Author

See if the section naming on the last commit works.

Yes, I think two is good. I just didn't want to add one (unpaired) heading. I try to follow old skool outlining rules and pair sections (and bullets) when possible.

@BrennanConroy
Copy link
Copy Markdown
Member

Another nit: the section about the clients should probably go above the first subsection now?
From "In the JavaScript client, the token can be provided..." to "To support this on the server, additional configuration is required:"

@guardrex guardrex merged commit d94bb6d into master Oct 22, 2020
@guardrex guardrex deleted the guardrex-patch-2 branch October 22, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignalR Core Auth - Token in Query String section does not address AddIdentityServerJwt()

2 participants