Skip to content

Obsolete Kestrel's Libuv transport#21081

Merged
guardrex merged 5 commits into
masterfrom
halter73/26245
Dec 31, 2020
Merged

Obsolete Kestrel's Libuv transport#21081
guardrex merged 5 commits into
masterfrom
halter73/26245

Conversation

@halter73
Copy link
Copy Markdown
Member

@halter73 halter73 commented Dec 30, 2020

@guardrex
Copy link
Copy Markdown
Collaborator

I'll edit and merge first thing Thursday morning (4am ... 😢 ... when the 😼 wakes me up!).

@guardrex guardrex self-assigned this Dec 30, 2020
Copy link
Copy Markdown
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor concern on the headings. Recently, the docs build system has been throwing warnings for headings duplicated across versions because rendering them produces heading tags with identical id values (e.g., <h2 id="libuv-transport-configuration">). We've been using a few approaches to work around this. However, the build thus far 🤞 isn't flaking out. Let's see how it goes. If I notice that this PR leads to warnings later, I'll follow this up with a PR to fix heading warnings.

@guardrex guardrex merged commit 1592afd into master Dec 31, 2020
@guardrex guardrex deleted the halter73/26245 branch December 31, 2020 11:38
@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Jan 6, 2021

Thanks @halter73!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.0 docs: Obsolete the Libuv transport

4 participants