Obsolete Kestrel's Libuv transport#21081
Merged
Merged
Conversation
jkotalik
approved these changes
Dec 30, 2020
Collaborator
|
I'll edit and merge first thing Thursday morning (4am ... 😢 ... when the 😼 wakes me up!). |
f0734fd to
7bfe98a
Compare
guardrex
approved these changes
Dec 31, 2020
Collaborator
guardrex
left a comment
There was a problem hiding this comment.
There's a minor concern on the headings. Recently, the docs build system has been throwing warnings for headings duplicated across versions because rendering them produces heading tags with identical id values (e.g., <h2 id="libuv-transport-configuration">). We've been using a few approaches to work around this. However, the build thus far 🤞 isn't flaking out. Let's see how it goes. If I notice that this PR leads to warnings later, I'll follow this up with a PR to fix heading warnings.
Member
|
Thanks @halter73! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Review
Fixes dotnet/aspnetcore#26245