Binding select multiple#22770
Merged
Merged
Conversation
41 tasks
MackinnonBuck
approved these changes
Jul 22, 2021
Member
MackinnonBuck
left a comment
There was a problem hiding this comment.
Looks great! Just one small suggestion 😃
Member
|
Also, no,
|
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Collaborator
Author
|
Thanks @MackinnonBuck! 🎷 I'll hold this PR for Preview 7 release. |
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Collaborator
Author
|
@MackinnonBuck ... This PR is blocking me from making other top priority updates for version-by-file (these topics need to move for that set of updates), so this PR has to go in now. I've added a line to each of the new sections that reads ...
... and I've made a note on the 6.0 tracking issue to remove that line when Preview 7 releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22448
Addresses #22448
🛑
HOLD FOR RELEASE OF PREVIEW 7🛑 We're going to go ahead with the coverage BUT with a comment that it applies to Preview 7. This is blocking other work. I'll revert the added comment when Preview 7 releases (tracked by the 6.0 tracking issue).On the PR:
nullbinding behavior section from the Forms Validation topic to the Data Binding topic and cross-links to it from Forms Validation. Cross-links also from each topic's new multiple select feature coverage.Question ❓:
For
InputSelect, themultipleattribute is inferred when bound to an array type. However, the example for binding<select>doesn't exhibit the same setup in the PU repo sample ...https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/testassets/BasicTestApp/SelectVariantsComponent.razor
Is inferred
multiplea thing for binding<select>, too, and the sample just doesn't show it? If so, I'll mirror theInputSelectcoverage remark in the<select>coverage and probably modify the<select>coverage example to dropmultiplein that scenario, too (i.e., let it infer the attribute as theInputSelectexample does).