Skip to content

Blazor control head content#22931

Merged
guardrex merged 5 commits into
mainfrom
guardrex/blazor-head-content
Aug 3, 2021
Merged

Blazor control head content#22931
guardrex merged 5 commits into
mainfrom
guardrex/blazor-head-content

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Aug 2, 2021

Addresses #20319
Addresses #22045

Internal Review Topic

  • This will be the 2nd step of a 🤠 Texas Three-step™ 💃🕺 (a dance that I just made up). This PR can be merged after revision and approval. The 3rd step will need to wait until RC1 to flesh out prerendering and integration guidance with local testing.
  • To move forward with the upcoming Preview 7 release coverage, I call out the upcoming release in an INCLUDE for _Layout.cshtml and have a one-liner at the top of the new topic on controlling <head> content. I'll back these out as soon as Preview 7 is available.

@guardrex guardrex mentioned this pull request Aug 2, 2021
41 tasks
@guardrex guardrex marked this pull request as ready for review August 3, 2021 10:51
@guardrex guardrex requested a review from MackinnonBuck August 3, 2021 10:51
Copy link
Copy Markdown
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

I just had one small suggestion for SetTitleAndDescription.razor. Other than that I think it's good to go 😃

Comment thread aspnetcore/6.0/blazor/components/control-head-content.md Outdated
guardrex and others added 3 commits August 3, 2021 11:39
@guardrex guardrex merged commit d9a59ff into main Aug 3, 2021
@guardrex guardrex deleted the guardrex/blazor-head-content branch August 3, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants