Blazor DynamicComponent coverage#22984
Conversation
|
Hey Luke, sorry for the delay but this looks great! Yeah, a lot of it was early days when I wrote it so I didn't expand on a lot of topics. As such, if this deviates from the post (which is no big deal!) no worries about taking my name off the byline. 😀 |
|
It can stay as long as you like. This is based on your post. If you reach a point that you want off of this (and the CSS isolation topic), let me know (or submit a PR changing them to me). I think the MVP folks like to see this sort of thing, so I recommend leaving it at least until you confirm keeping that status. |
|
Thanks so much - you're too good to me. I appreciate that. |
|
I'll merge this shortly after making one more edit pass. I'll ask the PU to look later during RC1. They're all 🏃🏃🏃😅 right now working on 6.0 things. |
|
@daveabrock ... Ok ... I think looks fine for a draft-ish preview doc. I'll come back to this at RC1 to make sure that it actually works 😄 (I hate when I put up docs that don't work. 🤦♂️) I'll also review+edit the whole thing at that time. I'll leave this here for a few hours to give you a chance to run a final 👁️ over it this morning and then merge it. |
|
Looks good to me, @guardrex! |
|
Thanks @daveabrock! 🎷 |
Addresses #22045
Fixes #22005
Internal Review Topic
@daveabrock ... See how this is shaping up thus far.