Skip to content

Blazor DynamicComponent coverage#22984

Merged
guardrex merged 5 commits into
mainfrom
guardrex/blazor-dynamiccomponent2
Aug 9, 2021
Merged

Blazor DynamicComponent coverage#22984
guardrex merged 5 commits into
mainfrom
guardrex/blazor-dynamiccomponent2

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Aug 9, 2021

Addresses #22045
Fixes #22005

Internal Review Topic

@daveabrock ... See how this is shaping up thus far.

  • Follows your general blog post layout.
  • Loosely follows your examples. However, I wasn't clear on why you had the types in the metadata for the passing parameters piece. You don't have the full implementation shown in your post, so I'm not sure how you use your metadata dictionary. I just keep the parameters and the name (for display) in the metadata and generate the options from it. Also, the naming might still be a bit dodgy ... I'm still working on that a bit.
  • I'm not on the new bits yet. I tend to adopt preview releases starting with RC1 (for stability in what I'm documenting). This merely looks like 👀 it will work ... maybe 😆 ... or not 💥😆.

@guardrex guardrex mentioned this pull request Aug 9, 2021
41 tasks
@daveabrock
Copy link
Copy Markdown
Contributor

daveabrock commented Aug 9, 2021

Hey Luke, sorry for the delay but this looks great! Yeah, a lot of it was early days when I wrote it so I didn't expand on a lot of topics. As such, if this deviates from the post (which is no big deal!) no worries about taking my name off the byline. 😀

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 9, 2021

It can stay as long as you like. This is based on your post. If you reach a point that you want off of this (and the CSS isolation topic), let me know (or submit a PR changing them to me). I think the MVP folks like to see this sort of thing, so I recommend leaving it at least until you confirm keeping that status.

@daveabrock
Copy link
Copy Markdown
Contributor

Thanks so much - you're too good to me. I appreciate that.

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 9, 2021

I'll merge this shortly after making one more edit pass. I'll ask the PU to look later during RC1. They're all 🏃🏃🏃😅 right now working on 6.0 things.

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 9, 2021

@daveabrock ... Ok ... I think looks fine for a draft-ish preview doc. I'll come back to this at RC1 to make sure that it actually works 😄 (I hate when I put up docs that don't work. 🤦‍♂️) I'll also review+edit the whole thing at that time. I'll leave this here for a few hours to give you a chance to run a final 👁️ over it this morning and then merge it.

@daveabrock
Copy link
Copy Markdown
Contributor

Looks good to me, @guardrex!

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 9, 2021

Thanks @daveabrock! 🎷

@guardrex guardrex merged commit 6b09df7 into main Aug 9, 2021
@guardrex guardrex deleted the guardrex/blazor-dynamiccomponent2 branch August 9, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor DynamicComponent

2 participants