Skip to content

Blazor 6.0 query string enhancements#23000

Merged
guardrex merged 8 commits into
mainfrom
guardrex/blazor-qs
Aug 12, 2021
Merged

Blazor 6.0 query string enhancements#23000
guardrex merged 8 commits into
mainfrom
guardrex/blazor-qs

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Aug 11, 2021

Fixes #22689
Addresses #22045

Internal Review Topic (links directly to the NavManager table section; the Query strings section immediately follows)

Mackinnon ...

  • I'd normally 🛌😴 one more night, but let's get this in quickly 🏃. It will be reviewed again at RC.

  • Most of this PR pertains to the query string bits, but I do add the replace guidance for NavigateTo while I'm here.

  • URI vs. URL: The API rightly uses "URI" ... but for practical purposes around the doc set, we use URL because that's specifically and usually what the dev is working with. Here, "URI" is used in text near API remarks, and "URL" is generally used elsewhere.

  • + and %20 in encoding. Let's NOT get deep into the weeds on it! 😄 lol ... There's a delta in the blog post remarks/examples. I think we want %20 everywhere.

  • WRT the example tables for URL mods: Don't sweat what looks like awfully wide table cells at this point. Yes! ... they are scary 😨 W....I....D....E for rendering 😄. I want to see how they render in the live topic, then I'll make mods to the display on a follow-up PR as needed. I gave your test code names the Rex treatment 😆 ... movie stars from Serenity.

    mruniverse

    Can't stop the signal, Mack. Everything goes somewhere, and I go everywhere. - Mr. Universe (David Krumholtz)

    Quote ©2005 Universal Pictures: Serenity https://www.uphe.com/movies/serenity David Krumholtz on IMDB: https://www.imdb.com/name/nm0472710/

@guardrex guardrex mentioned this pull request Aug 11, 2021
41 tasks
@guardrex guardrex marked this pull request as ready for review August 12, 2021 11:45
@guardrex guardrex requested a review from MackinnonBuck August 12, 2021 12:15
Copy link
Copy Markdown
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a small suggestion relating to the removal some functionality from GetUriWithQueryParameter. The tables are a great idea - I agree they are a useful way to illustrate the exact behavior of these APIs. I also agree that it's fine to use %20 everywhere.

Comment thread aspnetcore/blazor/fundamentals/routing.md Outdated
Comment thread aspnetcore/blazor/fundamentals/routing.md
@guardrex guardrex merged commit fac225e into main Aug 12, 2021
@guardrex guardrex deleted the guardrex/blazor-qs branch August 12, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor querystring enhancements

2 participants