Skip to content

RP/MVC CSS Isolation#23389

Merged
guardrex merged 5 commits into
mainfrom
guardrex/css-isolation
Oct 2, 2021
Merged

RP/MVC CSS Isolation#23389
guardrex merged 5 commits into
mainfrom
guardrex/css-isolation

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Sep 27, 2021

Fixes #23120
Addresses #22045

Probably best if we go includes on this one to centralize the coverage for both hosting models. Blazor is different enough that I'm going to leave our dedicated Blazor CSS isolation topic in place. The RP/MVC INCLUDES file is placed into the RP overview and the MVC views overview. There are cross-links among RP/MVC/Blazor scenarios.

Internal Review Topics:

NOTE: Although the MVC coverage for CSS isolation is only added to the MVC views overview on this PR, I noticed that we have a section ToC embedded in the MVC overview topic. This PR drops that as a side-NIT because we have doc sidebar ToCs. I elevate the 3rd level headings to 2nd level so that they'll show up over there.

cc: @daveabrock ... I added you to topic bylines because we're going to repurpose a lot of your Blazor coverage for this.

@guardrex guardrex mentioned this pull request Sep 27, 2021
41 tasks
@daveabrock
Copy link
Copy Markdown
Contributor

Hey @guardrex - I can look later in the week, but unfortunately do not have time at the moment.

@guardrex
Copy link
Copy Markdown
Collaborator Author

@daveabrock ... Yes, that's cool. If you would need to look after Friday, then I'll go ahead and merge this after Rick's suggestions and signoff. You could look at the live topic after Friday and then perhaps open a touch-up PR if you want. Such a PR would only need to modify one file. The INCLUDES file (includes/css-isolation.md) contains the coverage for both RP and MVC guidance.

@guardrex guardrex marked this pull request as ready for review October 1, 2021 22:30
@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Oct 1, 2021

@Rick-Anderson ... Would u like to review this, or do you want to just let the PU look later? We're planning on a PU look at the Blazor 6.0 updates post-RC2, and this bit will be part of that review.

@guardrex guardrex merged commit a932212 into main Oct 2, 2021
@guardrex guardrex deleted the guardrex/css-isolation branch October 2, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RP/MVC CSS isolation coverage for 6.0

3 participants