RP/MVC CSS Isolation#23389
Merged
Merged
Conversation
41 tasks
Contributor
|
Hey @guardrex - I can look later in the week, but unfortunately do not have time at the moment. |
Collaborator
Author
|
@daveabrock ... Yes, that's cool. If you would need to look after Friday, then I'll go ahead and merge this after Rick's suggestions and signoff. You could look at the live topic after Friday and then perhaps open a touch-up PR if you want. Such a PR would only need to modify one file. The INCLUDES file ( |
Collaborator
Author
|
@Rick-Anderson ... Would u like to review this, or do you want to just let the PU look later? We're planning on a PU look at the Blazor 6.0 updates post-RC2, and this bit will be part of that review. |
Rick-Anderson
approved these changes
Oct 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23120
Addresses #22045
Probably best if we go includes on this one to centralize the coverage for both hosting models. Blazor is different enough that I'm going to leave our dedicated Blazor CSS isolation topic in place. The RP/MVC INCLUDES file is placed into the RP overview and the MVC views overview. There are cross-links among RP/MVC/Blazor scenarios.
Internal Review Topics:
NOTE: Although the MVC coverage for CSS isolation is only added to the MVC views overview on this PR, I noticed that we have a section ToC embedded in the MVC overview topic. This PR drops that as a side-NIT because we have doc sidebar ToCs. I elevate the 3rd level headings to 2nd level so that they'll show up over there.
cc: @daveabrock ... I added you to topic bylines because we're going to repurpose a lot of your Blazor coverage for this.