Skip to content

Blazor Hybrid WPF tutorial (PR 4)#25043

Merged
guardrex merged 3 commits into
mainfrom
guardrex/blazor-hybrid-pr4
Feb 17, 2022
Merged

Blazor Hybrid WPF tutorial (PR 4)#25043
guardrex merged 3 commits into
mainfrom
guardrex/blazor-hybrid-pr4

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Feb 16, 2022

Addresses #24956

Internal Review Topic

  • There are few back-updates to the WinForms and MAUI tutorials.
  • Naming:
    • The app follows the prior convention ... ".NET MAUI Blazor" ... "WinForms Blazor" ... "WPF Blazor"
    • RCL: Follows the convention in the Blazor Class Libraries topic: "ComponentLibrary"
  • Follows the design of the WinForms tutorial: Merely rolls in a Counter component, not a full slate of Blazor project template components.

@guardrex guardrex mentioned this pull request Feb 16, 2022
25 tasks
@danroth27
Copy link
Copy Markdown
Member

Looks like the "services" error can be resolved by switching from StaticResource to DynamicResource in the XAML markup.

I'm not seeing the other compilation errors that you're getting when I pull your repo and build.

image

What VS version are you using? Which VS workloads do you have installed?

We should look at Toolbox integration for the WPF BlazorWebView, but yeah, it's not there yet. dotnet/maui#4730. The steps should instruct the user to manually add the BlazorWebView in XAML markup.

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Feb 16, 2022

The DynamicResource resolved everything for a successful build and then 🎉 ...

Capture

The steps should instruct the user to manually add the BlazorWebView in XAML markup.

Will do. 👍 I'm OOF the rest of today, and I should have it ready for review Thursday morning.

@guardrex guardrex marked this pull request as ready for review February 17, 2022 12:37
@guardrex guardrex closed this Feb 17, 2022
@guardrex guardrex reopened this Feb 17, 2022
Copy link
Copy Markdown
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@guardrex guardrex merged commit acc6197 into main Feb 17, 2022
@guardrex guardrex deleted the guardrex/blazor-hybrid-pr4 branch February 17, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants