Adding additional comment about FromServices optionality#25111
Merged
Conversation
Comment on lines
+628
to
+629
| > [!TIP] | ||
| > The binding will fail when obtaining an instance of a type, **not registered**, from the dependency injection container. If the service is expected to be **optional** then the parameter must be marked as nullable, including `?`, or set a default value. In this case, the method is responsible for the required check before the usage. |
Contributor
There was a problem hiding this comment.
Suggested change
| > [!TIP] | |
| > The binding will fail when obtaining an instance of a type, **not registered**, from the dependency injection container. If the service is expected to be **optional** then the parameter must be marked as nullable, including `?`, or set a default value. In this case, the method is responsible for the required check before the usage. | |
| > [!TIP] | |
| > Binding fails when attempting to bind to a type that isn't registered with the dependency injection container or isn't a .NET type. If the service is **optional**, the parameter must be one of the following: | |
| >* Marked as [nullable](/dotnet/csharp/language-reference/builtin-types/nullable-value-types). | |
| >* Have a default value. | |
| > | |
| > When using optional parameters, the app must check if the parameter is available. |
This might be closer. @serpent5 can you help out.
Contributor
There was a problem hiding this comment.
I've made an alternative suggestion below. I don't think this needs to be a tip, and I don't think we should link to the nullable docs as they're specific to value-types.
serpent5
reviewed
Feb 23, 2022
Co-authored-by: Kirk Larkin <6025110+serpent5@users.noreply.github.com>
Rick-Anderson
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25106.