Skip to content

Blazor Hybrid routing and nav topic#25130

Merged
guardrex merged 4 commits into
mainfrom
guardrex/blazor-hybrid-navigation
Feb 24, 2022
Merged

Blazor Hybrid routing and nav topic#25130
guardrex merged 4 commits into
mainfrom
guardrex/blazor-hybrid-navigation

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Feb 24, 2022

Addresses #24956

Internal Review Topic

Notes

  • These will be rough at first. I'll circle around later for niceties like API doc cross-links (when available), enhanced descriptions, fully-working, cut-'n-paste code examples, etc.
  • Although this PR doesn't include routing coverage, I think we'll probably be adding at least a brief remark that component routing (in a BlazorWebView) conforms to the coverage in the Blazor Fundamentals node topic on the subject with any caveats or gotchas 😈 that you want to call out. Fundamentals topic on routing/nav ... Does it all apply to Hybrid scenarios (BlazorWebView)?

@guardrex guardrex mentioned this pull request Feb 24, 2022
25 tasks
@guardrex guardrex requested a review from TanayParikh February 24, 2022 13:05
@TanayParikh
Copy link
Copy Markdown
Contributor

TanayParikh commented Feb 24, 2022

Thanks @guardrex. I'm going to hold off on reviewing till the original PR is merged, just in case there are minor changes like renaming the enum value.

cross linking dotnet/maui#4645

Copy link
Copy Markdown
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one minor formatting change. Thanks!

Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
@guardrex guardrex merged commit 92a6569 into main Feb 24, 2022
@guardrex guardrex deleted the guardrex/blazor-hybrid-navigation branch February 24, 2022 23:20
Comment thread aspnetcore/blazor/hybrid/routing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants