Skip to content

[SignalR] Document client results#25796

Merged
BrennanConroy merged 6 commits into
mainfrom
brecon/clientres
May 12, 2022
Merged

[SignalR] Document client results#25796
BrennanConroy merged 6 commits into
mainfrom
brecon/clientres

Conversation

@BrennanConroy
Copy link
Copy Markdown
Member

@BrennanConroy BrennanConroy commented May 4, 2022

Documenting new feature in SignalR added in dotnet/aspnetcore#40811

Review Url

@BrennanConroy BrennanConroy marked this pull request as ready for review May 4, 2022 21:32
Copy link
Copy Markdown
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the NITs. 🚀

Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md
Comment thread aspnetcore/signalr/hubs.md
Comment thread aspnetcore/signalr/hubs.md
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md Outdated
Comment thread aspnetcore/signalr/hubs.md
Comment thread aspnetcore/signalr/hubs.md
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
@BrennanConroy
Copy link
Copy Markdown
Member Author

cc @jcjiang, you don't show up in the reviewers drop down menu yet.

@bradygaster
Copy link
Copy Markdown
Member

Also think we need to feature this in the upcoming blog posts @JeremyLikness is driving.

Comment thread aspnetcore/signalr/hubs.md Outdated
@BrennanConroy
Copy link
Copy Markdown
Member Author

Was waiting for preview4 to be out before merging this. It came out two days ago, so merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants