-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Ra/request decompression middleware/david acker #26763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rick-Anderson
merged 8 commits into
main
from
ra/requestDecompression-middleware/david-acker
Aug 19, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f1e9f7
Add request decompression middleware sample
david-acker 34129ce
Merge branch 'main' into request-decompression-sample
david-acker bdb56be
Add to table of built-in middleware
david-acker 9f8f753
Clean up, fix typo
david-acker f3d5a77
minor cleanup of RequestDecompression middleware /8
Rick-Anderson 05b5fb8
minor cleanup of RequestDecompression middleware /8
Rick-Anderson a889b59
minor cleanup of RequestDecompression middleware /8
Rick-Anderson 31cda3e
react to feedback
Rick-Anderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
aspnetcore/fundamentals/middleware/request-decompression.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| --- | ||
| title: Request Decompression in ASP.NET Core | ||
| author: david-acker | ||
| description: Learn how to use the request decompression middleware in ASP.NET Core | ||
| monikerRange: '>= aspnetcore-7.0' | ||
| ms.author: riande | ||
| ms.date: 8/17/2022 | ||
| uid: fundamentals/middleware/request-decompression | ||
| --- | ||
| # Request decompression in ASP.NET Core | ||
|
|
||
| By [David Acker](https://github.com/david-acker) | ||
|
|
||
| Request decompression middleware: | ||
|
|
||
| * Enables API endpoints to accept requests with compressed content. | ||
| * Uses the [`Content-Encoding`](https://developer.mozilla.org/docs/Web/HTTP/Headers/Content-Encoding) HTTP header to automatically identify and decompress requests which contain compressed content. | ||
| * Eliminates the need to write code to handle compressed requests. | ||
|
|
||
| When the `Content-Encoding` header value on a request matches one of the available decompression providers, the middleware: | ||
|
|
||
| * Uses the matching provider to wrap the <xref:Microsoft.AspNetCore.Http.HttpRequest.Body?displayProperty=nameWithType> in an appropriate decompression stream. | ||
| * Removes the `Content-Encoding` header, indicating that the request body is no longer compressed. | ||
|
|
||
| Requests that don't include a `Content-Encoding` header are ignored by the request decompression middleware. | ||
|
|
||
| Decompression: | ||
|
|
||
| * Occurs when the body of the request is being read. That is, decompression occurs at the endpoint on model binding. The request body is not decompressed eagerly. | ||
| * When attempting to read the decompressed request body, if the compressed data is invalid for the specified `Content-Encoding`, an exception is thrown. | ||
|
|
||
| If the middleware encounters a request with compressed content but is unable to decompress it, the request is passed to the next delegate in the pipeline. For example, a request with an unsupported `Content-Encoding` header value or multiple `Content-Encoding` header values, is passed to the next delegate in the pipeline. For example, Brotli can throw `System.InvalidOperationException:` Decoder ran into invalid data, Deflate and GZip can throw `System.IO.InvalidDataException`: The archive entry was compressed using an unsupported compression method. | ||
|
|
||
| ## Configuration | ||
|
|
||
| The following code shows how to enable request decompression for the [default](#default) `Content-Encoding` types: | ||
|
|
||
| [!code-csharp[](samples/request-decompression/7.x/Program.cs?name=snippet_WithDefaultProviders&highlight=3,7)] | ||
|
|
||
| <a name="default"></a> | ||
|
|
||
| ## Default decompression providers | ||
|
|
||
| The `Content-Encoding` header values that the request decompression middleware supports by default are listed in the following table: | ||
|
|
||
| | [`Content-Encoding`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding) header values | Description | | ||
| | --------- | --------- | | ||
| | `br` | [Brotli compressed data format](https://tools.ietf.org/html/rfc7932) | | ||
| | `deflate` | [DEFLATE compressed data format](https://tools.ietf.org/html/rfc1951) | | ||
| | `gzip` | [Gzip file format](https://tools.ietf.org/html/rfc1952) | | ||
|
|
||
| ## Custom decompression providers | ||
|
|
||
| Support for custom encodings can be added by creating custom decompression provider classes that implement <xref:Microsoft.AspNetCore.RequestDecompression.IDecompressionProvider>: | ||
|
|
||
| [!code-csharp[](samples/request-decompression/7.x/CustomDecompressionProvider.cs?name=snippet_CustomDecompressionProvider)] | ||
|
|
||
| Custom decompression providers are registered with <xref:Microsoft.AspNetCore.RequestDecompression.RequestDecompressionOptions> along with their corresponding `Content-Encoding` header values: | ||
|
|
||
| [!code-csharp[](samples/request-decompression/7.x/Program.cs?name=snippet_WithCustomProvider&highlight=3-6,10)] | ||
|
|
||
| ## Request size limits | ||
|
|
||
| In order to guard against [zip bombs or decompression bombs](https://en.wikipedia.org/wiki/Zip_bomb): | ||
|
|
||
| * The maximum size of the decompressed request body is limited to the request body size limit enforced by the endpoint or server. | ||
| * If the number of bytes read from the decompressed request body stream exceeds the limit, an [InvalidOperationException](xref:System.InvalidOperationException) is thrown to prevent additional bytes from being read from the stream. | ||
|
|
||
| The maximum request size for an endpoint is set by: | ||
|
|
||
| * <xref:Microsoft.AspNetCore.Http.Metadata.IRequestSizeLimitMetadata.MaxRequestBodySize?displayProperty=nameWithType>, such as <xref:Microsoft.AspNetCore.Mvc.RequestSizeLimitAttribute> or <xref:Microsoft.AspNetCore.Mvc.DisableRequestSizeLimitAttribute> for MVC endpoints. | ||
| * The global server size limit <xref:Microsoft.AspNetCore.Http.Features.IHttpMaxRequestBodySizeFeature.MaxRequestBodySize?displayProperty=nameWithType>. If not set, [`MaxRequestBodySize`](https://github.com/dotnet/aspnetcore/blob/197c1693d3c830af52b587e8d88891bc9689be44/src/Servers/Kestrel/Core/src/KestrelServerLimits.cs#L148-L157) uses the [default value](https://github.com/dotnet/aspnetcore/blob/197c1693d3c830af52b587e8d88891bc9689be44/src/Servers/Kestrel/Core/src/KestrelServerLimits.cs#L153). `MaxRequestBodySize` can be overridden per request with [`IHttpMaxRequestBodySizeFeature.MaxRequestBodySize`](xref:Microsoft.AspNetCore.Http.Features.IHttpMaxRequestBodySizeFeature.MaxRequestBodySize) | ||
|
|
||
| > [!WARNING] | ||
| > Disabling the request body size limit poses a security risk in regards to uncontrolled resource consumption, particularly if the request body is being buffered. Ensure that safeguards are in place to mitigate the risk of [denial-of-service](https://www.cisa.gov/uscert/ncas/tips/ST04-015) (DoS) attacks. | ||
|
|
||
| ## Additional Resources | ||
|
|
||
| * <xref:fundamentals/middleware/index> | ||
| * [Mozilla Developer Network: Content-Encoding](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding) | ||
| * [Brotli Compressed Data Format](https://www.rfc-editor.org/rfc/rfc7932) | ||
| * [DEFLATE Compressed Data Format Specification version 1.3](https://www.rfc-editor.org/rfc/rfc1951) | ||
| * [GZIP file format specification version 4.3](https://www.rfc-editor.org/rfc/rfc1952) | ||
This file was deleted.
Oops, something went wrong.
14 changes: 14 additions & 0 deletions
14
.../fundamentals/middleware/samples/request-decompression/7.x/CustomDecompressionProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| using Microsoft.AspNetCore.RequestDecompression; | ||
|
|
||
| namespace RequestDecompressionSample; | ||
|
|
||
| #region snippet_CustomDecompressionProvider | ||
| public class CustomDecompressionProvider : IDecompressionProvider | ||
| { | ||
| public Stream GetDecompressionStream(Stream stream) | ||
| { | ||
| // Perform custom decompression logic here | ||
| return stream; | ||
| } | ||
| } | ||
| #endregion |
37 changes: 37 additions & 0 deletions
37
aspnetcore/fundamentals/middleware/samples/request-decompression/7.x/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #define WithDefaultProviders // WithDefaultProviders WithCustomProvider | ||
|
|
||
| using Microsoft.AspNetCore.Http.HttpResults; | ||
| using RequestDecompressionSample; | ||
|
|
||
| #if WithDefaultProviders | ||
| #region snippet_WithDefaultProviders | ||
| var builder = WebApplication.CreateBuilder(args); | ||
|
|
||
| builder.Services.AddRequestDecompression(); | ||
|
|
||
| var app = builder.Build(); | ||
|
|
||
| app.UseRequestDecompression(); | ||
|
|
||
| app.MapPost("/", (HttpRequest request) => Results.Stream(request.Body)); | ||
|
|
||
| app.Run(); | ||
| #endregion | ||
| #elif WithCustomProvider | ||
| #region snippet_WithCustomProvider | ||
| var builder = WebApplication.CreateBuilder(args); | ||
|
|
||
| builder.Services.AddRequestDecompression(options => | ||
| { | ||
| options.DecompressionProviders.Add("custom", new CustomDecompressionProvider()); | ||
| }); | ||
|
|
||
| var app = builder.Build(); | ||
|
|
||
| app.UseRequestDecompression(); | ||
|
|
||
| app.MapPost("/", (HttpRequest request) => Results.Stream(request.Body)); | ||
|
|
||
| app.Run(); | ||
| #endregion | ||
| #endif |
9 changes: 9 additions & 0 deletions
9
...ndamentals/middleware/samples/request-decompression/7.x/RequestDecompressionSample.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> | ||
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of exception? Since this is Stream, only a few types of exceptions are expected, like IOException.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the exceptions thrown by the underlying decompression stream implementations used by the default providers:
Brotli (BrotliStream):
Deflate (DeflateStream):
GZip (GZipStream):