Skip to content

Output caching documentation#27398

Merged
tdykstra merged 9 commits into
dotnet:mainfrom
tdykstra:outputcache
Nov 2, 2022
Merged

Output caching documentation#27398
tdykstra merged 9 commits into
dotnet:mainfrom
tdykstra:outputcache

Conversation

@tdykstra
Copy link
Copy Markdown
Contributor

@tdykstra tdykstra commented Oct 26, 2022

@Rick-Anderson Rick-Anderson marked this pull request as ready for review October 27, 2022 20:48
Copy link
Copy Markdown
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly opinionated nits, discard what you don't agree with.

Comment thread aspnetcore/includes/response-caching-mid.md Outdated
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md
Comment thread aspnetcore/performance/caching/output.md
Comment thread aspnetcore/performance/caching/output.md Outdated
@Rick-Anderson
Copy link
Copy Markdown
Contributor

Oh, and nice work.

Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
@tdykstra tdykstra changed the title WIP: Output caching documentation Output caching documentation Oct 31, 2022
@tdykstra tdykstra requested a review from sebastienros October 31, 2022 20:34
Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/output.md Outdated

Here are some of the options for controlling the cache key:

* <xref:Microsoft.AspNetCore.OutputCaching.OutputCachePolicyBuilder.SetVaryByQuery%2A> - Specify one or more query string names to act as the cache key.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to act as the cache key

I could understand it as "it now is the cache key". Technically it's adding something to the cache key, not "acting as the key"


* The cache storage medium is extensible.

Memory is used by default. Disk, Redis, blob storage, and others are available. Response caching is limited to memory.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disk, Redis, blob storage, and others are available.

They are not. But this is possible, users can implement it or maybe find it on nuget.

Comment thread aspnetcore/performance/caching/output.md Outdated
Comment thread aspnetcore/performance/caching/overview.md Outdated
Comment thread aspnetcore/performance/caching/overview.md Outdated
@tdykstra tdykstra requested a review from sebastienros November 1, 2022 21:12
@tdykstra tdykstra merged commit f8f20aa into dotnet:main Nov 2, 2022
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET 7: Output caching middleware

3 participants