Remove note about increasing MaximumParallelInvocationsPerClient#28003
Merged
Conversation
As of 7.0-rc1, this is no longer necessary
davidfowl
approved these changes
Jan 3, 2023
BrennanConroy
approved these changes
Jan 4, 2023
Donciavas
pushed a commit
to Donciavas/AspNetCore.Docs
that referenced
this pull request
Feb 7, 2024
…net#28003) As of 7.0-rc1, this is no longer necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 7.0-rc1, this is no longer necessary due to dotnet/aspnetcore#42796.
Should we add a caveat for this "con" mentioned int the PR description?
I think injecting an
IHubContextinto a hub might be too contrived of a scenario to be worth mentioning. Lengthening the docs to cover every edge case can make things overwhelming. On the other hand, it'd probably be pretty difficult to diagnose if you did happen to run into it.