Skip to content

Blazor Hybrid (MAUI) page-component navigation#28216

Merged
guardrex merged 5 commits into
mainfrom
guardrex/blazor-hybrid-routing
Jan 27, 2023
Merged

Blazor Hybrid (MAUI) page-component navigation#28216
guardrex merged 5 commits into
mainfrom
guardrex/blazor-hybrid-routing

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Jan 27, 2023

Fixes #25872

Thanks @Christoph1972! 🚀 ... Sorry for the delay. We had a busy .NET 7 release cycle for docs late last year. I'm just now wrapping up last year's lower-priority issues ⛰️⛏️😅.

Internal Review Topic

David ...

  • I blatantly stole 🚓👮 some of your language from the issue 😄. Thanks for those remarks.
  • Thanks again for the MainPage tip. I felt there was one silly thing 😈 that I was doing wrong. I've placed that change here to head off anyone else from missing it. It also plays into my fully-working, cut-'n-paste examples effort across the Blazor docs node. Since I started providing these a few years ago, the number of docs issues has dropped dramatically.
  • I've made the example generic for modal or modeless nav. It starts modeless in the example and mentions the changes to make it modal at the end.
  • Check my naming because I'm not familiar with .NET MAUI conventions. For example, would it be typical to place content pages for a hybrid-type app in a "Views" folder? Did I name elements/controls/methods well?
  • Are there any version deltas between .NET 6 and .NET 7 for this content? Currently, this is versioned for >= 6.0.

WRT similar content for WPF and WinForms, I'm going to hold off on that for now. I'll ask Dan and Artak about that offline later today. If they want that coverage, I'll open a new issue for it.

@guardrex guardrex self-assigned this Jan 27, 2023
@guardrex guardrex requested a review from davidbritch January 27, 2023 12:34
Copy link
Copy Markdown
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so that you're unblocked, but with comments.

Comment thread aspnetcore/blazor/hybrid/routing.md
Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
Comment thread aspnetcore/blazor/hybrid/routing.md
Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
Comment thread aspnetcore/blazor/hybrid/routing.md Outdated
@davidbritch
Copy link
Copy Markdown
Contributor

  • Are there any version deltas between .NET 6 and .NET 7 for this content? Currently, this is versioned for >= 6.0.

It's all good (no version deltas).

guardrex and others added 2 commits January 27, 2023 11:33
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@guardrex guardrex merged commit c37c18f into main Jan 27, 2023
@guardrex guardrex deleted the guardrex/blazor-hybrid-routing branch January 27, 2023 17:45
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing basics of navigation for hybrid app

2 participants