Skip to content

Draft-WIP: ModelState.AddModelError /2#28445

Merged
Rick-Anderson merged 7 commits into
mainfrom
ra/modelBinding
Mar 3, 2023
Merged

Draft-WIP: ModelState.AddModelError /2#28445
Rick-Anderson merged 7 commits into
mainfrom
ra/modelBinding

Conversation

@Rick-Anderson
Copy link
Copy Markdown
Contributor

@Rick-Anderson Rick-Anderson commented Feb 18, 2023

@Rick-Anderson Rick-Anderson mentioned this pull request Feb 18, 2023
@Rick-Anderson Rick-Anderson changed the title ModelState.AddModelError /2 Draft-WIP: ModelState.AddModelError /2 Feb 22, 2023
@Rick-Anderson Rick-Anderson marked this pull request as ready for review March 3, 2023 01:47
@Rick-Anderson Rick-Anderson merged commit 48f960f into main Mar 3, 2023
@Rick-Anderson Rick-Anderson deleted the ra/modelBinding branch March 3, 2023 01:49
@Rick-Anderson
Copy link
Copy Markdown
Contributor Author

@sammychinedu2ky you got credit for the merge. Can you review my changes here and open an issue if you see any problems.

@Rick-Anderson
Copy link
Copy Markdown
Contributor Author

Arg, it doesn't look like you got credit, even though you were the first commit. I'll have to watch author when I do this again, but it doesn't look like there's any way to select the author.

@sammychinedu2ky
Copy link
Copy Markdown
Contributor

Sure that's fine . But where do you check if I got credit or not cause I can see my commit in the commit tab. Is there somewhere else that you check? @Rick-Anderson

@Rick-Anderson
Copy link
Copy Markdown
Contributor Author

image

Looks like they changed how they determine who gets credit. I'll find something else for you to get that credit back.

@sammychinedu2ky
Copy link
Copy Markdown
Contributor

Sure no worries. 😅

Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
* changed date😎

* IResult model binding and testing /2

* work

* work

* work

* work

* work

---------

Co-authored-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model Validation should mention ModelState.AddModelError

2 participants