Conversation
Member
This language looks good to me. @Eilon , what do you think? |
Collaborator
Author
|
Shall we wait on @Eilon to look at that phrasing before merging? |
Eilon
approved these changes
Apr 18, 2023
Contributor
Eilon
left a comment
Eilon
left a comment
There was a problem hiding this comment.
Yeah I think this is fine, thanks for checking. If for some reason we ever see in the future that it is unclear to someone, we can revisit, but I'd be surprised.
Donciavas
pushed a commit
to Donciavas/AspNetCore.Docs
that referenced
this pull request
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28965
cc: @mkArtakMSFT ... I can see that Surayya did the PR ... I'll ping for review.
Notes:
Do we want to use this language to describe the default start path? ...
... because I'm not aware if it's possible for these apps to have a different base path. I'll modify to your best choice of language there.
Just FYI ... Across the Hybrid docs, we use the approach for setting properties on a
BlazorWebViewthat the tutorials adopt. In the case where the dev is looking at the XAML markup code, we show the setting on the element, not via the designer property tools. In the WinForms case, we set those properties in C#, so that's what we place here. We assume the reader used our tutorials, so we assume they'll work with the properties across the docs the same way as the tutorials have them work with them. Just letting you know. This is subject to change later perhaps, but this is the approach we're using thus far.