Monitor Blazor Server circuit activity#28983
Conversation
MackinnonBuck
left a comment
There was a problem hiding this comment.
This looks great! Just a small suggestion.
I don't think there's anything else this PR needs to cover 🙂
|
@MackinnonBuck ... I think we have a bit more to look at and resolve on this one. Two things leap out now that I know what "there's an existing pattern for accessing circuit-scoped services" was referring to. I've updated the PR for the following, but you'll need to look and see if iNsAnItY 😵 has taken over the small 🦖🧠...
If you want to look at the published previews, they can be reached with the following links (these link directly to the sections) ...
|
|
@MackinnonBuck ... I think you should take a look at the updated layout. I'm primarily concerned about item 2 above ☝️. I may have guessed correctly on the implementation of the |
|
@guardrex I think the updated layout looks great. Regarding the |
|
Thanks @MackinnonBuck ... I like what I wrote (and the example) in the Access |
|
Thanks @javiercn.
MERGING NOW! 🏃 |
Fixes #28982
Mackinnon ... this looks like your bits. Half the time, I'll get the PU assignment via Artak. On this one, I think he'll ask you to look. This comes right from Dan's blog post, so it's probably ok as a basic guide. Are there more feature nits and bits that we need to discuss here?
https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-dotnet-8-preview-3/#monitor-blazor-server-circuit-activity
Internal previews