Conversation
96 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30093
Steve, for ...
Do you want me to draft up something like that now, table it for later (like 24Q1), or not place coverage for that at all?
If you want me to take a 🔪 at it, I'll need some info on triggering
NotifyChangedAsyncfrom a service because the tests at ...https://github.com/dotnet/aspnetcore/blob/f902a5b27cf2d89e555a1cf67ae796d11dab039e/src/Components/Components/test/CascadingParameterTest.cs#L571-L635
... new up the
CascadingValueSourcein the method. How isNotifyChangedAsynccalled in a service? What am I registering/injecting to call it because it apparently isn't directly related to the cascading parameter.Also ...
Do you have an example cross-link? What I have here is fun, but I could tack on a quick real world example.
Internal previews