Conversation
|
@Rick-Anderson @tdykstra @wadepickett ... Sébastien Sougnez's Twitter link in an article byline broke and appears in the build report. I'm fixing it on this PR, but it will go in later today because this needs a PU review from Mackinnon. |
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
|
I'm a bit worried that our change in structure to the In hindsight, it would have been great if we adjusted |
Filed dotnet/aspnetcore#51611 to track this. |
|
@MackinnonBuck @danroth27 ... I went with showing both standalone WASM and Blazor Server in a SxS format with BWA scripts for >=8.0, and I leave WASM/Server code to appear for <8.0. I didn't use pivots ... just vanilla versioning. 🛑 NOTE TO SELF ✋
UPDATE: There's a new Blazor script location section now in the Project Structure article. I'll be linking to it from across the doc set for Blazor script location. |
|
@MackinnonBuck ... The last commit:
I think we can leave the remaining references (placeholder remarks) in the Fundamentals > Startup article as they are. |
MackinnonBuck
left a comment
There was a problem hiding this comment.
Looks great 🙂
I left an additional comment here, but don't feel obligated to make any changes if you like things the way they are!
Fixes #30812
Fixes #30580
Fixes #30862
Mackinnon ... You might want to expand the entire Startup doc on the diff to confirm that nothing else needs to change.
Also, confirm if the brace blocks (
{...}) passed tossr,circuit, andwebAssemblyare called "functions" in this context. If not, what should they be called? You'll see on the DIFF (Lines 51-53) where we need to change the word if I made a poor choice.The bit that I added on an earlier PR for
disableDomPreservationis versioned for 8.0+ at the end of the doc.Internal previews
Toggle expand/collapse