Server-side behaviors during static SSR#32048
Merged
Conversation
Member
MackinnonBuck
left a comment
There was a problem hiding this comment.
Some smallish suggestions - might be good to get @javiercn's input before merging
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Collaborator
Author
|
No response to the ping. Let's go ahead and take reader feedback at this point. If anything is amiss, I'm sure that I'll hear about it ... readers will sharpen their BEAKS and CLAWS 🦅 for me 😨😆. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31402
Thanks @FengRuikai! 🚀
I'm mostly going off of Javier's sentiment expressed here ...
dotnet/aspnetcore#52176 (comment)
... and I'm cleaning up the approach for how we can convey this information:
<NotAuthorized>content in the Security article.<NotFound>content in the Routing and Layouts articles.Also, are there any other scenarios that fall into this bucket outside of
<NotFound>and<NotAuthorized>content that we should add to the list here (and cross-link from outside the article)?... and btw ... you'll see a few other small wording changes ...
Those updates are just things that I thought I could improve in passing. They don't pertain to the PR or the issue, but I recommend looking 👀 at those additional updates given the general complexity of the coverage.
Internal previews