Conversation
Rick-Anderson
approved these changes
Sep 30, 2024
Contributor
Rick-Anderson
left a comment
There was a problem hiding this comment.
A++ work as usual for you.
Collaborator
Author
|
I think we'll go ahead and merge this tomorrow (Monday) EOD. I think the only significant question is on if env vars offer enough protection for test/staging. Right now, the updates on this PR advise not to use them except in local dev testing, along with the Secret Manager tool. |
Collaborator
Author
|
BTW ... As soon as this goes in, I'll be updating the BWA+OIDC sample app and article with guidance to use the Secret Manager tool for the client secret. Tracked by 👉 #33804. As for the upcoming BWA+Entra sample app and article, it will be set up in the PR that establishes the article. |
Collaborator
Author
|
@Rick-Anderson ... Try it now. I ended up using "recommendation" language similar to what you used on your PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33744
Fixes #33784
I needed a special INCLUDE for Blazor to distinguish between client-side/SPA and server-side Blazor projects. I also prefer to use the word "project" in the BWA/server-side context over "app" because BWA/hosted WASM is a solution of two or more projects that have different security requirements.
Internal previews
Toggle expand/collapse