Merged
Conversation
MackinnonBuck
approved these changes
Dec 2, 2024
Member
|
Sorry, I should have commented first, then approved. My bad! |
Member
Not in particular - I think it's enough to call out that they exist. I actually added them because we had a need for them in the framework itself. |
Collaborator
Author
|
I'll submit a patch, but I'm on the treadmill running off a lot of 🦃🦃🦃🦃😆. I'll update this by EOD before it goes live. UPDATE: Patched on #34262. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34086
Addresses #31909
Per dotnet/aspnetcore#58630.
They seem straightforward enough. I didn't see tests for the new events in the framework. Do you have any specific example(s) that you'd like to show for them?
Also, I'm not sure if using the word "load" in the way that I have for the description is correct for
enhancedload. 👀Internal previews