replace old versions SDK with latest released /1#35269
Merged
Merged
Conversation
Contributor
|
Test
Sent from iPhone
…________________________________
From: Rick Anderson ***@***.***>
Sent: Friday, April 18, 2025 3:29:10 PM
To: dotnet/AspNetCore.Docs ***@***.***>
Cc: Tom Dykstra ***@***.***>; Review requested ***@***.***>
Subject: Re: [dotnet/AspNetCore.Docs] replace old versions SDK with latest released /1 (PR #35269)
@Rick-Anderson<https://github.com/Rick-Anderson> requested your review on: #35269<#35269> replace old versions SDK with latest released /1.
—
Reply to this email directly, view it on GitHub<#35269 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAL7GY5ULXYDHZTVIHPRPC322F4DNAVCNFSM6AAAAAB3NXH6BSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGMZDKNJXHA4DCNA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
tdykstra
reviewed
Apr 21, 2025
Contributor
There was a problem hiding this comment.
Correct me if I'm missing something, but I think the options here are to say:
- Version x is required. (This is what we have currently -- x is the actual version the tutorial was tested with.
- Version x or later is required. (x is still the actual version the tutorial was tested with but we're not implicitly excluding later versions, as we are in no.1).
- The latest released version is required. (This is the proposed change in this PR. Can leave people who actually have the correct version for the tutorial thinking they can't use it.)
I prefer no.2 as the most accurate statement of what is required. No.2 could be made more comprehensive by adding "Changes may be required if you use a version later than x."
tdykstra
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35199
Internal previews