Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the push notifications documentation to improve security guidance and standardize security warnings. The changes implement a consistent approach to handling private keys in ASP.NET Core applications by replacing custom security warnings with a standardized include file.
- Adds AI-usage metadata and updates the document date
- Replaces custom security warning text with a standardized include file reference
- Enhances security guidance with additional cryptographic best practices
tdykstra
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35747
Tom, Wade ... Just need a single review on this one, too.
Originally, I planned to add a section on how to grab a Key Vault certificate's private and public keys for this, but there's just no time. I'm booked for several months between 10.0 and 'Blazorfy It!'™ issues. I don't even want to keep a backlog issue on this because I wouldn't reach it until at least 2026. However, I did make a tracking entry on #34434 to consider it next year.
After trying a few different approaches, I've settled on ...
Internal previews