Catch a more general exception and report it#4895
Merged
Rick-Anderson merged 1 commit intodotnet:masterfrom Nov 29, 2017
guardrex:patch-6
Merged
Catch a more general exception and report it#4895Rick-Anderson merged 1 commit intodotnet:masterfrom guardrex:patch-6
Rick-Anderson merged 1 commit intodotnet:masterfrom
guardrex:patch-6
Conversation
Contributor
|
@guardrex I agree, nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: File Uploads section of RP tutorial (FileHelper.cs)
When the
StreamReaderchokes on bytes for a Unicode conversion, it throws aDecoderFallbackException:I recommend we catch a more general exception and then just report the error
Messageback to the user.The result of this will look like this in the UI ...