Skip to content

Missing ContentPlaceHolder in master page#4899

Merged
scottaddie merged 4 commits intodotnet:masterfrom
Sadegh-Ameri:patch-5
Nov 30, 2017
Merged

Missing ContentPlaceHolder in master page#4899
scottaddie merged 4 commits intodotnet:masterfrom
Sadegh-Ameri:patch-5

Conversation

@Sadegh-Ameri
Copy link
Copy Markdown
Contributor

@Sadegh-Ameri Sadegh-Ameri commented Nov 30, 2017

When creating a new PR, please do the following and delete this template text:

  • Reference the issue number if there is one:

    Fixes #Issue_Number

    The "Fixes #nnn" syntax in the PR description causes
    GitHub to automatically close the issue when this PR is merged.

Internal Review Page

@scottaddie scottaddie self-requested a review November 30, 2017 15:30
@scottaddie
Copy link
Copy Markdown
Member

scottaddie commented Nov 30, 2017

Note to self: Build relies on sample8.html file added in PR #4898

@scottaddie
Copy link
Copy Markdown
Member

Closing and reopening to trigger the build...

@scottaddie scottaddie closed this Nov 30, 2017
@scottaddie scottaddie reopened this Nov 30, 2017
@scottaddie scottaddie merged commit b183405 into dotnet:master Nov 30, 2017
@scottaddie
Copy link
Copy Markdown
Member

@Sadegh-Ameri Thank you again for taking the time to add this missing step.

@Sadegh-Ameri
Copy link
Copy Markdown
Contributor Author

Thank you Scott for taking the time to revise and merge to master.
Sorry, I was not familiar with the notation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants