Skip to content

Fixing sample code to use ASP.NET Core 2.x DefaultHostBuilder to setup a host#5095

Closed
seprix91 wants to merge 1 commit into
dotnet:masterfrom
seprix91:patch-1
Closed

Fixing sample code to use ASP.NET Core 2.x DefaultHostBuilder to setup a host#5095
seprix91 wants to merge 1 commit into
dotnet:masterfrom
seprix91:patch-1

Conversation

@seprix91
Copy link
Copy Markdown

@seprix91 seprix91 commented Jan 3, 2018

Though, creating a host from WebHostBuilder is supported approach, it sounds 1.x though. Took liberty to upgrade sample to use more compact static CreateDefaultBuilder method

Though, creating a host from WebHostBuilder is supported approach, it sounds 1.x though. Took liberty to upgrade sample to use more compact static CreateDefaultBuilder method
@dnfclas
Copy link
Copy Markdown

dnfclas commented Jan 3, 2018

CLA assistant check
All CLA requirements met.

@scottaddie scottaddie self-requested a review January 3, 2018 21:23
@scottaddie
Copy link
Copy Markdown
Member

@seprix91 We'll need to display both 1.x and 2.x snippets in this doc. That is accomplished by using tabs. See the following doc for an example of tabs and the syntax: https://docs.microsoft.com/aspnet/core/security/authentication/identity-configuration. Is this something you have time to do? If not, I can take care of it.

@seprix91
Copy link
Copy Markdown
Author

seprix91 commented Jan 6, 2018

@scottaddie Thanks for the clarification. yes, i can do that.

@scottaddie
Copy link
Copy Markdown
Member

@seprix91 Thanks for your help! Let me know if you have any questions.

@guardrex
Copy link
Copy Markdown
Collaborator

Thanks @seprix91 for raising this issue/PR. I'm going to close here and perform user experience update on the topic along with the 2.0 sample update. #5315

Thanks again! 🚀

@guardrex guardrex closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants