Allow reflecting on DebuggableAttribute on CoreRT#1055
Conversation
|
Benchmark.NET is targeting .NET Standard 2.0: https://github.com/dotnet/BenchmarkDotNet/blob/master/src/BenchmarkDotNet/BenchmarkDotNet.csproj#L5. These methods are available in .NET Standard 2.0. Would it be better to just avoid the reflection altogether? |
|
@MichalStrehovsky big thanks for the PR! I am glad I am not the only user of our CoreRtToolchain anymore! @jkotas you are right, the comments in the code are from the dnx or netcoreapp1.0 era ;) |
|
I am going to merge this now and fix the way we use this attribute. I am going to also add one more integration test to make sure we support the latest version of CoreRT. So far our tests were running against const version of CoreRT: |
You should add telemetry. I'm sure there's many of us :). |
See dotnet/corert#6955 (comment).
BenchmakeDotNet reflects on this attribute here:
BenchmarkDotNet/src/BenchmarkDotNet/Extensions/AssemblyExtensions.cs
Lines 28 to 38 in a76f438