Skip to content

Update advanced-performance-topics.md#4898

Merged
roji merged 3 commits intodotnet:mainfrom
azarboon:patch-1
Dec 6, 2024
Merged

Update advanced-performance-topics.md#4898
roji merged 3 commits intodotnet:mainfrom
azarboon:patch-1

Conversation

@azarboon
Copy link
Copy Markdown
Contributor

@azarboon azarboon commented Dec 6, 2024

Connection pooling and relationship between EF and ADO isn't explained well in the documentation (AFAIK). I've added it to clarify it. Given the authority of the doc, it should clearly explain it.

Comment thread entity-framework/core/performance/advanced-performance-topics.md Outdated
Tweaked it according to feedback
@azarboon
Copy link
Copy Markdown
Contributor Author

azarboon commented Dec 6, 2024

@roji thanks for your feedback. I've tweaked it accordingly. Please let me know your advice.

@roji
Copy link
Copy Markdown
Member

roji commented Dec 6, 2024

Thanks @azarboon. I've pushed a commit proposing some tweaks; we need to also keep in mind that EF supports non-relational providers as well, where ADO.NET doesn't play any role (and in fact, no pooling is done or needed, since there's no persistent connection).

Let me know if this looks OK to you.

@azarboon
Copy link
Copy Markdown
Contributor Author

azarboon commented Dec 6, 2024

Thanks @azarboon. I've pushed a commit proposing some tweaks; we need to also keep in mind that EF supports non-relational providers as well, where ADO.NET doesn't play any role (and in fact, no pooling is done or needed, since there's no persistent connection).

Let me know if this looks OK to you.

@roji Excellent. Looks great. Please sign it off

@roji roji merged commit 1fa7d58 into dotnet:main Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants