Add missing HostNameInCertificate property in NetFx Ref#1776
Merged
cheenamalhotra merged 2 commits intomainfrom Oct 4, 2022
Merged
Add missing HostNameInCertificate property in NetFx Ref#1776cheenamalhotra merged 2 commits intomainfrom
cheenamalhotra merged 2 commits intomainfrom
Conversation
David-Engel
approved these changes
Sep 27, 2022
Codecov ReportBase: 71.37% // Head: 71.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
+ Coverage 71.37% 71.40% +0.02%
==========================================
Files 293 293
Lines 61376 61929 +553
==========================================
+ Hits 43808 44219 +411
- Misses 17568 17710 +142
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lcheunglci
approved these changes
Sep 27, 2022
Contributor
|
I have seen this happen before with another new connection string property. Wonder if it would be possible to author a general test to prevent this from happening again? |
Member
Author
|
Maybe time to revive #1307 and enable "Package" reference tests to be run once in a while.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.