Fix DAC connections to localhost in managed SNI#1865
Merged
David-Engel merged 3 commits intodotnet:mainfrom Dec 16, 2022
Merged
Fix DAC connections to localhost in managed SNI#1865David-Engel merged 3 commits intodotnet:mainfrom
David-Engel merged 3 commits intodotnet:mainfrom
Conversation
Codecov ReportBase: 70.68% // Head: 70.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
- Coverage 70.68% 70.21% -0.47%
==========================================
Files 292 292
Lines 61727 61728 +1
==========================================
- Hits 43629 43341 -288
- Misses 18098 18387 +289
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
David-Engel
requested review from
DavoudEshtehari,
JRahnama,
Kaur-Parminder and
lcheunglci
lcheunglci
approved these changes
Dec 16, 2022
DavoudEshtehari
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1772. When connecting to the DAC port, the previous code was converting localhost to Environment.MachineName. Native SNI does it the other way around. It converts Environment.MachineName to localhost.