Add JSON Support Feature Extension#2531
Conversation
|
@deepaksa1 can we also add the processing of acknowledgement of this feature extension and expose a flag which says whether the connection supports this feature? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
- Coverage 72.80% 72.77% -0.03%
==========================================
Files 311 311
Lines 61709 61732 +23
==========================================
- Hits 44928 44927 -1
- Misses 16781 16805 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
You will have to make changes to the netfx part of the code too |
apoorvdeshmukh
left a comment
There was a problem hiding this comment.
Is there an existing unit test which is testing these WriteXXXFeatureRequest() functions? Do we need changes there?
@apoorvdeshmukh there are no such unit tests to target these specific functions. However @deepaksa1 perhaps it would be nice to enhance the TDS server which is a mock server to see if this feature extension is received by the server. Some examples of test using the mock server are https://github.com/dotnet/SqlClient/blob/main/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs#L25 It might be worth looking at extending TDSFeatureExtAckSessionStateOption in the tests to provide a response for JSON feature extension as well. |
|
You need to make changes to https://github.com/dotnet/SqlClient/blob/main/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs as well and the related files for netfx. |
This PR aims to add a new feature extension to support JSON type in SqlClient.